Arm backend: Update full quantization annotation #14585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
full, full.default and fill_.Scalar were previously part of _one_to_one_shared_input_or_input_act_qspec without having any input nodes. This meant that these nodes were never annotated and solely relied on the next node to annotate its input. This patch changes so that full, full.default and fill_.Scalar are annotated in the same way as scalar_tensor.default. Also adds these targets to _is_large_scalar(). Signed-off-by: Oscar Andersson <[email protected]> Change-Id: I9266c493bb2945c2b9f09ec67c731aedb58a23b8
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14585
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 9 Unrelated FailuresAs of commit 7430caa with merge base ce6e2cf ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
oscarandersson8218
added
partner: arm
|
Arm no-fvp CI is failing, else lgtm. |
digantdesai
approved these changes
Oct 1, 2025
|
re-run seem to help, it a unrelated flakey test I have flagged it internaly at Arm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
full, full.default and fill_.Scalar were previously part of one_to_one_shared_input_or_input_act_qspec without having any input nodes. This meant that these nodes were never annotated and solely relied on the next node to annotate its input. This patch changes so that full, full.default and fill.Scalar are annotated in the same way as scalar_tensor.default.
Also adds these targets to _is_large_scalar().
cc @digantdesai @freddan80 @per @zingo